Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci.yml: silence invalid linter complaints on use of logp.TestingSetup #36474

Merged
merged 1 commit into from
Aug 31, 2023

Commits on Aug 31, 2023

  1. golangci.yml: silence invalid linter complaints on use of logp.Testin…

    …gSetup
    
    A logp.TestingSetup call can only fail when no logp.ToObserverOutput()
    option has been provided and one of syslog, file or event log output has
    been selected. There is no case in the code base where this is true.
    So disable the errcheck linter for this function.
    
    The only way that the function can return an error is when a user makes
    use of a custom logp.Option function since none of the provided Options
    alter the logp.Config to cause output to failable destinations.
    efd6 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f7f05c5 View commit details
    Browse the repository at this point in the history