-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Processor\Script] Add option to prevent creation of new sessions #40692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 4, 2024
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
strawgate
added
the
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
label
Sep 4, 2024
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 4, 2024
faec
approved these changes
Sep 5, 2024
leehinman
reviewed
Sep 6, 2024
leehinman
approved these changes
Sep 6, 2024
strawgate
added
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.15
labels
Sep 10, 2024
jlind23
added
backport-8.15
Automated backport to the 8.15 branch with mergify
backport-8.x
Automated backport to the 8.x branch with mergify
and removed
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.15
Automated backport to the 8.15 branch with mergify
labels
Sep 12, 2024
Merged
6 tasks
strawgate
added a commit
that referenced
this pull request
Sep 13, 2024
…0692) (#40793) * Add option to prevent new session creation and pre-create cached sessions (cherry picked from commit 3f3b988) Co-authored-by: William Easton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
backport-8.15
Automated backport to the 8.15 branch with mergify
enhancement
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40690
Proposed commit message
Include an option called
only_cached_sessions
that causes the script processor to only use the pre-defined cached javascript sessions from the session pool. This option is off by default. Includes some unrelated fixes for lint errors related to unchecked errors returned by called functions.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
No
Use cases
Prevent the Beat from temporarily allocating and deleting hundreds of javascript sessions during normal operation.
Allows using more expensive Javascript scripts knowing they will only undergo initialization a single time.
Allows funneling all Beat events through a single session