Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Processor\Script] Add option to prevent creation of new sessions #40692

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

strawgate
Copy link
Contributor

@strawgate strawgate commented Sep 4, 2024

Fixes #40690

Proposed commit message

Include an option called only_cached_sessions that causes the script processor to only use the pre-defined cached javascript sessions from the session pool. This option is off by default. Includes some unrelated fixes for lint errors related to unchecked errors returned by called functions.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

No

Use cases

Prevent the Beat from temporarily allocating and deleting hundreds of javascript sessions during normal operation.

Allows using more expensive Javascript scripts knowing they will only undergo initialization a single time.

Allows funneling all Beat events through a single session

@strawgate strawgate requested a review from a team as a code owner September 4, 2024 17:58
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 4, 2024
Copy link
Contributor

mergify bot commented Sep 4, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @strawgate? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@strawgate strawgate added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 4, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 4, 2024
@strawgate strawgate merged commit 3f3b988 into main Sep 9, 2024
124 checks passed
@strawgate strawgate deleted the 40690 branch September 9, 2024 23:28
@strawgate strawgate added backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 labels Sep 10, 2024
@jlind23 jlind23 added backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify labels Sep 12, 2024
mergify bot pushed a commit that referenced this pull request Sep 12, 2024
…0692)

* Add option to prevent new session creation and pre-create cached sessions

(cherry picked from commit 3f3b988)
strawgate added a commit that referenced this pull request Sep 13, 2024
…0692) (#40793)

* Add option to prevent new session creation and pre-create cached sessions

(cherry picked from commit 3f3b988)

Co-authored-by: William Easton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Script" Processor should be able to operate with only cached sessions
5 participants