Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skip link checks or warn link checks but not both #2844

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Allow skip link checks or warn link checks but not both #2844

merged 1 commit into from
Dec 1, 2023

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Nov 30, 2023

This PR addressed @gtback comment here

gtback
gtback approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gtback
Copy link
Member

gtback commented Nov 30, 2023 •
edited
Loading

Error: Unable to resolve action elastic/docs@main, unable to find version main

😕

EDIT: Ah, this line should be master since the docs repo doesn't have a main branch

      - uses: elastic/docs/.github/actions/docs-preview@main

@nkammah nkammah merged commit cefde70 into master Dec 1, 2023
6 of 7 checks passed
@nkammah nkammah deleted the fix-bk-job-options branch December 1, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtback gtback gtback approved these changes

@colleenmcginnis colleenmcginnis Awaiting requested review from colleenmcginnis

@kilfoyle kilfoyle Awaiting requested review from kilfoyle

@leemthompo leemthompo Awaiting requested review from leemthompo

@scottybollinger scottybollinger Awaiting requested review from scottybollinger scottybollinger was automatically assigned from elastic/docs-engineering

@glitteringkatie glitteringkatie Awaiting requested review from glitteringkatie glitteringkatie was automatically assigned from elastic/docs-engineering

@bmorelli25 bmorelli25 Awaiting requested review from bmorelli25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkammah @gtback