Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skip link checks or warn link checks but not both #2844

Merged
merged 1 commit into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .buildkite/scripts/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ fi

if [[ "${BROKEN_LINKS}" == 'skiplinkcheck' ]]; then
broken_links_opt="--skiplinkcheck"
else
if [[ "${BROKEN_LINKS}" == 'warnlinkcheck' ]]; then
broken_links_opt="--warnlinkcheck"
fi
elif [[ "${BROKEN_LINKS}" == 'warnlinkcheck' ]]; then
broken_links_opt="--warnlinkcheck"
fi

if [[ "${BUILDKITE_BRANCH}" == "master" ]]; then
Expand Down
5 changes: 2 additions & 3 deletions .buildkite/scripts/build_pr.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@ if [[ ${GITHUB_PR_COMMENT_VAR_REBUILD_OPT:="unset"} == "rebuild" ]];then
rebuild_opt=" --rebuild"
elif [[ ${GITHUB_PR_COMMENT_VAR_SKIP_OPT:="unset"} == "skiplinkcheck" ]];then
build_args+=" --skiplinkcheck"
if [[ ${GITHUB_PR_COMMENT_VAR_WARN_OPT:="unset"} == "warnlinkcheck" ]];then
build_args+=" --warnlinkcheck"
fi
elif [[ ${GITHUB_PR_COMMENT_VAR_WARN_OPT:="unset"} == "warnlinkcheck" ]];then
build_args+=" --warnlinkcheck"
fi

buildkite-agent \
Expand Down
Loading