Generate license report on jar build #409
Conversation
agent/build.gradle.kts
Outdated
| // include licenses and notices in jar | ||
| from(rootDir) { | ||
| dependsOn(fullLicenseReport) | ||
| from(fullLicenseReport.get().outputs.files.singleFile) { |
There was a problem hiding this comment.
Usually passing a task as input for another task is enough for gradle to create an implicit dependency between them and also to know what outputs to consume. Some cases might need things to be done explicitly though, maybe this is one of them, but if it's not, I think it'd be enough to replace lines 44 and 45 with from(fullLicenseReport).
There was a problem hiding this comment.
Also, it seems like this config is applied the same way in the agentextension build file, if the same steps are needed for all cases then it'd probably be nice to do this work in the conventions file.
There was a problem hiding this comment.
I think it'd be enough to replace lines 44 and 45 with from(fullLicenseReport)
Good point, i wasn't aware that from() accepts tasks as input, thanks!
Also, it seems like this config is applied the same way in the agentextension build file, if the same steps are needed for all cases then it'd probably be nice to do this work in the conventions file.
I left that intentionally in the individual sub-projects: In my opinion it is easier to follow when the content-packaging of the JAR is less spread over multiple files, especially in this case because it is now only two duplicated lines across the two files.
buildSrc/src/main/kotlin/elastic-otel.license-report-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
Closes #386.
Instead of checking licenses into git, the license report is instead generated when the JAR-artifacts are built.
I manually compared the results of the new build with the contents prior to this PR. Prior to this PR the license report also included compile-only dependencies, which are now left out because to my knowledge they are not required: We only need to have the licenses of the dependencies we actually ship.
To manage license approval, I've included the
checkLicensetask: This way the build will fail if licenses are detected, which have not been approved explicitly via thebuildscripts/allowed-licenses.jsonfile.