Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate license report on jar build #409
Generate license report on jar build #409
Changes from 3 commits
75f04ea
a647d16
48b1566
83cf8ca
acda4ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually passing a task as input for another task is enough for gradle to create an implicit dependency between them and also to know what outputs to consume. Some cases might need things to be done explicitly though, maybe this is one of them, but if it's not, I think it'd be enough to replace lines 44 and 45 with
from(fullLicenseReport)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it seems like this config is applied the same way in the
agentextension
build file, if the same steps are needed for all cases then it'd probably be nice to do this work in the conventions file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, i wasn't aware that
from()
accepts tasks as input, thanks!I left that intentionally in the individual sub-projects: In my opinion it is easier to follow when the content-packaging of the JAR is less spread over multiple files, especially in this case because it is now only two duplicated lines across the two files.
This file was deleted.
This file was deleted.
This file was deleted.