[Tech debt] Fix Jest unit tests on broken on React 17 #7227
Conversation
package.json
Outdated
| "test-unit:ts": "cross-env NODE_ENV=test jest --config ./scripts/jest/config.js --testMatch **/*.test.ts", | ||
| "test-unit:ts:17": "cross-env NODE_ENV=test REACT_VERSION=17 jest --config ./scripts/jest/config.js --testMatch **/*.test.ts", | ||
| "test-unit:tsx": "cross-env NODE_ENV=test jest --config ./scripts/jest/config.js --testMatch **/*.test.tsx", | ||
| "test-unit:tsx:17": "cross-env NODE_ENV=test REACT_VERSION=17 jest --config ./scripts/jest/config.js --testMatch **/*.test.tsx", |
There was a problem hiding this comment.
We'd previously discussed reviewers entering these commands into the CLI, but then I remembered how much of a pain they were to get running. I opted to add the short commands into package.json so they would be quicker to test and give myself the hooks I want for when I split the Buildkite job.
There was a problem hiding this comment.
I would strongly prefer writing this as a script that accepts args instead of adding a bunch of extremely repetitive scripts to our package.json, so I went ahead and did so in c3072d8 and 9a7212d. Let me know if you have any questions - I've updated your PR description with the new corresponding flags, as well as updated our wiki docs. I'll (eventually) add comment to the original PR's docker commands as well with the new flags
| it('updates the overlay controls once the screen is smaller than 1.5x the flyout width', () => { | ||
| mockWindowResize(320); | ||
| const { baseElement, getByTestSubject } = render( | ||
| const { baseElement, getByLabelText, getByTestSubject } = render( | ||
| <EuiCollapsibleNavBeta>Nav content</EuiCollapsibleNavBeta> | ||
| ); | ||
| expect(getByLabelText('Toggle navigation open')).toBeInTheDocument(); | ||
| fireEvent.click(getByTestSubject('euiCollapsibleNavButton')); | ||
| expect(baseElement).toMatchSnapshot(); | ||
| expect(getByLabelText('Toggle navigation closed')).toBeInTheDocument(); |
There was a problem hiding this comment.
I added a second snapshot test for rendering at mobile size, and added this interaction test to verify the mobile behavior. That's why the snapshot shows reduced and changed lines.
- instead of creating scripts that devs aren't going to use
CLI will use this to test react vs non react files
…ersions + clean up assertions
- this is an `it renders` type test, so no getting around a snapshot for each version
…ement - should only be passed to resize observer
cee-chen
changed the title
[17, 18]
+ dry out scripts
+ update CI to test using `yarn
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
Summary
PR provides script commands to run
.tsand.tsxtests against React[17, 18]with no errors. This PR will be combined with a few others to split our Buildkitetestjob to run in parallel.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
Best way to QA will be to run the following commands after pulling the branch and
yarnto ensure latest dependencies:yarn test-unit --testMatch=non-reactyarn test-unit --react-version=17 --testMatch=reactyarn test-unit --react-version=16 --testMatch=reactyarn test-unit --testMatch=reactyarn test-unitfor a final no-regressions check