Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech debt] Fix Jest unit tests on broken on React 17 #7227

Merged
merged 10 commits into from
Sep 29, 2023
Merged

[Tech debt] Fix Jest unit tests on broken on React 17 #7227

merged 10 commits into from
Sep 29, 2023

Commits on Sep 26, 2023

  1. Basic changes to pass TSX unit tests on React 17.

    @1Copenut
    1Copenut committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    53969b4 View commit details
    Browse the repository at this point in the history

  2. Added script command for TS tests on React 17, 18.

    @1Copenut
    1Copenut committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    1e5b243 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. [PR feedback] Simplify test-unit step with configurable yargs 

    - instead of creating scripts that devs aren't going to use
    @cee-chen
    cee-chen committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c3072d8 View commit details
    Browse the repository at this point in the history

  2. Add testMatch script to new script 

    CLI will use this to test react vs non react files
    @cee-chen
    cee-chen committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9a7212d View commit details
    Browse the repository at this point in the history

  3. Update wiki

    @cee-chen
    cee-chen committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3c5234b View commit details
    Browse the repository at this point in the history

  4. [EuiCollapsibleNav] Remove all snapshots so tests pass on all react v… 

    …ersions

+ clean up assertions
    @cee-chen
    cee-chen committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    6cbb5d5 View commit details
    Browse the repository at this point in the history

  5. [EuiDataGrid keyboard shortcuts] render snapshots for each react version 

    - this is an `it renders` type test, so no getting around a snapshot for each version
    @cee-chen
    cee-chen committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1f3a3b8 View commit details
    Browse the repository at this point in the history

  6. [EuiTextTruncate] Fix onResize getting incorrectly spread to DOM el… 

    …ement

- should only be passed to resize observer
    @cee-chen
    cee-chen committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    c760c39 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. [misc cleanup] rename cypress node file to match others 

    + dry out scripts
    @cee-chen
    cee-chen committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    ffc80e8 View commit details
    Browse the repository at this point in the history

  2. Bake in --node-options flag to test scripts 

    + update CI to test using `yarn
    @cee-chen
    cee-chen committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    24ce92e View commit details
    Browse the repository at this point in the history