Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes] Enable tsdb by default #6159

Merged
merged 4 commits into from
May 15, 2023

Conversation

tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented May 11, 2023

What does this PR do?

This PR enables TSDB for Kubernetes package by default.
Note:

elasticsearch:
  index_mode: "time_series"

is not set only for 1 data_stream: events. There will be created a dedicated github issue fix event data_stream and enable TSDB.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-05-15 at 16 08 11

Signed-off-by: Tetiana Kravchenko <[email protected]>
@elasticmachine
Copy link

elasticmachine commented May 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-15T14:16:36.508+0000

  • Duration: 30 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 11, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 96.154% (75/78) 👍 0.916
Lines 100.0% (0/0) 💚 12.766
Conditionals 100.0% (0/0) 💚

Signed-off-by: Tetiana Kravchenko <[email protected]>
@tetianakravchenko tetianakravchenko marked this pull request as ready for review May 11, 2023 18:29
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner May 11, 2023 18:29
@tetianakravchenko tetianakravchenko changed the title [Kubernetes] enable tsdb by default [Do not merge] [Kubernetes] enable tsdb by default May 11, 2023
@tetianakravchenko tetianakravchenko changed the title [Do not merge] [Kubernetes] enable tsdb by default [Kubernetes] Enable tsdb by default May 15, 2023
Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - similar to #6129

Assuming all data streams here work fine with TSDB enabled.

@tetianakravchenko tetianakravchenko merged commit 20c5a54 into elastic:main May 15, 2023
@elasticmachine
Copy link

Package kubernetes - 1.40.0-beta containing this change is available at https://epr.elastic.co/search?package=kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants