-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Notes] - fix notes management page search crash #187934
[Security Solution][Notes] - fix notes management page search crash #187934
Conversation
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
x-pack/plugins/security_solution/public/notes/components/search_row.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
8519109
to
f561da7
Compare
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
|
f561da7
to
300dee7
Compare
…lastic#187934) (cherry picked from commit 2958be7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…crash (#187934) (#188047) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution][Notes] - fix notes management page search crash (#187934)](#187934) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-11T06:26:49Z","message":"[Security Solution][Notes] - fix notes management page search crash (#187934)","sha":"2958be7303f40cc055a983760a5a9f45b42386fe","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.15.0","v8.16.0"],"title":"[Security Solution][Notes] - fix notes management page search crash","number":187934,"url":"https://github.com/elastic/kibana/pull/187934","mergeCommit":{"message":"[Security Solution][Notes] - fix notes management page search crash (#187934)","sha":"2958be7303f40cc055a983760a5a9f45b42386fe"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187934","number":187934,"mergeCommit":{"message":"[Security Solution][Notes] - fix notes management page search crash (#187934)","sha":"2958be7303f40cc055a983760a5a9f45b42386fe"}}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Summary
This PR fixes a crash happening on the new Notes Management page, when entering special characters to the search bar. According to EUI docs for the
EuiSearchBar
, we shouldn't pass thequery
to the component unless it's controlled outside. In our case, it's only done via user input within the component.Before
Screen.Recording.2024-07-10.at.9.22.37.AM.mov
After
Screen.Recording.2024-07-10.at.9.22.06.AM.mov
#187734