[Security Solution][Notes] - fix notes management page search crash #187934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
janmonschke
reviewed
Jul 10, 2024
x-pack/plugins/security_solution/public/notes/components/search_row.tsx
Outdated
Show resolved
Hide resolved
PhilippeOberti
force-pushed
the
fix-notes-management-search-crash
branch
from
8519109
to
f561da7
Compare
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
History
|
kqualters-elastic
approved these changes
Jul 10, 2024
PhilippeOberti
force-pushed
the
fix-notes-management-search-crash
branch
from
f561da7
to
300dee7
Compare
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 11, 2024
…lastic#187934) (cherry picked from commit 2958be7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 11, 2024
…crash (#187934) (#188047) # Backport This will backport the following commits from `main` to `8.15`: - [[Security Solution][Notes] - fix notes management page search crash (#187934)](#187934) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-11T06:26:49Z","message":"[Security Solution][Notes] - fix notes management page search crash (#187934)","sha":"2958be7303f40cc055a983760a5a9f45b42386fe","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.15.0","v8.16.0"],"title":"[Security Solution][Notes] - fix notes management page search crash","number":187934,"url":"https://github.com/elastic/kibana/pull/187934","mergeCommit":{"message":"[Security Solution][Notes] - fix notes management page search crash (#187934)","sha":"2958be7303f40cc055a983760a5a9f45b42386fe"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187934","number":187934,"mergeCommit":{"message":"[Security Solution][Notes] - fix notes management page search crash (#187934)","sha":"2958be7303f40cc055a983760a5a9f45b42386fe"}}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a crash happening on the new Notes Management page, when entering special characters to the search bar. According to EUI docs for the
EuiSearchBar, we shouldn't pass thequeryto the component unless it's controlled outside. In our case, it's only done via user input within the component.Before
Screen.Recording.2024-07-10.at.9.22.37.AM.mov
After
Screen.Recording.2024-07-10.at.9.22.06.AM.mov
#187734