-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Fix AI Assistant Settings when plugin disabled #188160
[Obs AI Assistant] Fix AI Assistant Settings when plugin disabled #188160
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
/ci |
/ci |
const observabilityFeatureDisabledInSpaceMsg = i18n.translate( | ||
'aiAssistantManagementSelection.aiAssistantSelectionPage.observabilityAi.thisFeatureIsDisabledInSpaceCallOutLabel', | ||
{ | ||
defaultMessage: 'This feature is disabled. It can be enabled from Spaces > Features', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgieselaar It was decided to keep the message simple instead of distinguishing between the states so it now only says "This feature is disabled" with the existing label.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
…astic#188160) ## Summary Fixes elastic#187977 AI Assistant settings page doesn't load when the plugin is disabled. ### Changes - fixes not checking for object before accessing property - simplifies message so it makes sense for all possible states (read only, disabled in space, plugin disabled) ### Testing steps - create a Viewer user - go to Stack Management -> Advanced Settings -> AI Assistant - page should load with message that the feature is disabled <img width="804" alt="Screenshot 2024-07-11 at 4 57 59 PM" src="https://github.com/user-attachments/assets/98cf85a2-913f-43fd-a5f0-df4494faaf1f"> (cherry picked from commit d4ba879)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…led (#188160) (#188347) # Backport This will backport the following commits from `main` to `8.15`: - [[Obs AI Assistant] Fix AI Assistant Settings when plugin disabled (#188160)](#188160) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sandra G","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-07-15T17:58:02Z","message":"[Obs AI Assistant] Fix AI Assistant Settings when plugin disabled (#188160)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/187977\r\n\r\nAI Assistant settings page doesn't load when the plugin is disabled. \r\n\r\n### Changes\r\n\r\n- fixes not checking for object before accessing property\r\n- simplifies message so it makes sense for all possible states (read\r\nonly, disabled in space, plugin disabled)\r\n\r\n### Testing steps\r\n- create a Viewer user\r\n- go to Stack Management -> Advanced Settings -> AI Assistant\r\n- page should load with message that the feature is disabled\r\n\r\n<img width=\"804\" alt=\"Screenshot 2024-07-11 at 4 57 59 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/98cf85a2-913f-43fd-a5f0-df4494faaf1f\">","sha":"d4ba87988da61dc793ba5982fa0bbc28034bf449","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Obs AI Assistant","v8.15.0","v8.16.0"],"title":"[Obs AI Assistant] Fix AI Assistant Settings when plugin disabled","number":188160,"url":"https://github.com/elastic/kibana/pull/188160","mergeCommit":{"message":"[Obs AI Assistant] Fix AI Assistant Settings when plugin disabled (#188160)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/187977\r\n\r\nAI Assistant settings page doesn't load when the plugin is disabled. \r\n\r\n### Changes\r\n\r\n- fixes not checking for object before accessing property\r\n- simplifies message so it makes sense for all possible states (read\r\nonly, disabled in space, plugin disabled)\r\n\r\n### Testing steps\r\n- create a Viewer user\r\n- go to Stack Management -> Advanced Settings -> AI Assistant\r\n- page should load with message that the feature is disabled\r\n\r\n<img width=\"804\" alt=\"Screenshot 2024-07-11 at 4 57 59 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/98cf85a2-913f-43fd-a5f0-df4494faaf1f\">","sha":"d4ba87988da61dc793ba5982fa0bbc28034bf449"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/188160","number":188160,"mergeCommit":{"message":"[Obs AI Assistant] Fix AI Assistant Settings when plugin disabled (#188160)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/187977\r\n\r\nAI Assistant settings page doesn't load when the plugin is disabled. \r\n\r\n### Changes\r\n\r\n- fixes not checking for object before accessing property\r\n- simplifies message so it makes sense for all possible states (read\r\nonly, disabled in space, plugin disabled)\r\n\r\n### Testing steps\r\n- create a Viewer user\r\n- go to Stack Management -> Advanced Settings -> AI Assistant\r\n- page should load with message that the feature is disabled\r\n\r\n<img width=\"804\" alt=\"Screenshot 2024-07-11 at 4 57 59 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/98cf85a2-913f-43fd-a5f0-df4494faaf1f\">","sha":"d4ba87988da61dc793ba5982fa0bbc28034bf449"}}]}] BACKPORT--> Co-authored-by: Sandra G <[email protected]>
Summary
Fixes #187977
AI Assistant settings page doesn't load when the plugin is disabled.
Changes
Testing steps