[8.15] [Obs AI Assistant] Fix AI Assistant Settings when plugin disabled (#188160) #188347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…astic#188160) ## Summary Fixes elastic#187977 AI Assistant settings page doesn't load when the plugin is disabled. ### Changes - fixes not checking for object before accessing property - simplifies message so it makes sense for all possible states (read only, disabled in space, plugin disabled) ### Testing steps - create a Viewer user - go to Stack Management -> Advanced Settings -> AI Assistant - page should load with message that the feature is disabled <img width="804" alt="Screenshot 2024-07-11 at 4 57 59 PM" src="https://github.com/user-attachments/assets/98cf85a2-913f-43fd-a5f0-df4494faaf1f"> (cherry picked from commit d4ba879)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
cc @neptunian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.15:Questions ?
Please refer to the Backport tool documentation