Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution][Notes] - fix the notes link that is shown twice in the search bar (#198200) #198255

Merged
merged 1 commit into from
Oct 30, 2024

Commits on Oct 30, 2024

  1. [Security Solution][Notes] - fix the notes link that is shown twice i…

    …n the search bar (elastic#198200)
    
    ## Summary
    
    This PR fixes a minor inconvenience where the Kibana search bar was
    showing 2 entries for the new Notes management page.
    
    | Before fix | After fix |
    | ------------- | ------------- |
    | ![Screenshot 2024-10-29 at 11 53
    44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)
    | ![Screenshot 2024-10-29 at 11 53
    19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)
    |
    
    Notes: this fix does not fix an issue happening in the space-specific
    search, where Notes, Timelines and maybe other entries are appearing
    twice. That issue seems to be related to the way we are removing then
    adding back links to work with the new navigation. I looked into it but
    could not find a way to fix yet, so this will be part of a follow up PR
    
    elastic#197694
    (cherry picked from commit ac5c74a)
    PhilippeOberti committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ae28d61 View commit details
    Browse the repository at this point in the history