Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution][Notes] - fix the notes link that is shown twice in the search bar (#198200) #198255

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…n the search bar (elastic#198200)

## Summary

This PR fixes a minor inconvenience where the Kibana search bar was
showing 2 entries for the new Notes management page.

| Before fix | After fix |
| ------------- | ------------- |
| ![Screenshot 2024-10-29 at 11 53
44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)
| ![Screenshot 2024-10-29 at 11 53
19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)
|

Notes: this fix does not fix an issue happening in the space-specific
search, where Notes, Timelines and maybe other entries are appearing
twice. That issue seems to be related to the way we are removing then
adding back links to work with the new navigation. I looked into it but
could not find a way to fix yet, so this will be part of a follow up PR

elastic#197694
(cherry picked from commit ac5c74a)
@kibanamachine kibanamachine merged commit 3feea7b into elastic:8.x Oct 30, 2024
39 checks passed
PhilippeOberti added a commit that referenced this pull request Oct 30, 2024
…twice in the search bar (#198200) (#198366)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution][Notes] - fix the notes link that is shown twice
in the search bar
(#198200)](#198200)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T08:33:04Z","message":"[Security
Solution][Notes] - fix the notes link that is shown twice in the search
bar (#198200)\n\n## Summary\r\n\r\nThis PR fixes a minor inconvenience
where the Kibana search bar was\r\nshowing 2 entries for the new Notes
management page.\r\n\r\n| Before fix | After fix |\r\n| ------------- |
------------- |\r\n| ![Screenshot 2024-10-29 at 11
53\r\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\r\n|
![Screenshot 2024-10-29 at 11
53\r\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\r\n|\r\n\r\nNotes:
this fix does not fix an issue happening in the
space-specific\r\nsearch, where Notes, Timelines and maybe other entries
are appearing\r\ntwice. That issue seems to be related to the way we are
removing then\r\nadding back links to work with the new navigation. I
looked into it but\r\ncould not find a way to fix yet, so this will be
part of a follow up
PR\r\n\r\nhttps://github.com//issues/197694","sha":"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","v8.16.0","v8.17.0"],"number":198200,"url":"https://github.com/elastic/kibana/pull/198200","mergeCommit":{"message":"[Security
Solution][Notes] - fix the notes link that is shown twice in the search
bar (#198200)\n\n## Summary\r\n\r\nThis PR fixes a minor inconvenience
where the Kibana search bar was\r\nshowing 2 entries for the new Notes
management page.\r\n\r\n| Before fix | After fix |\r\n| ------------- |
------------- |\r\n| ![Screenshot 2024-10-29 at 11
53\r\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\r\n|
![Screenshot 2024-10-29 at 11
53\r\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\r\n|\r\n\r\nNotes:
this fix does not fix an issue happening in the
space-specific\r\nsearch, where Notes, Timelines and maybe other entries
are appearing\r\ntwice. That issue seems to be related to the way we are
removing then\r\nadding back links to work with the new navigation. I
looked into it but\r\ncould not find a way to fix yet, so this will be
part of a follow up
PR\r\n\r\nhttps://github.com//issues/197694","sha":"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198200","number":198200,"mergeCommit":{"message":"[Security
Solution][Notes] - fix the notes link that is shown twice in the search
bar (#198200)\n\n## Summary\r\n\r\nThis PR fixes a minor inconvenience
where the Kibana search bar was\r\nshowing 2 entries for the new Notes
management page.\r\n\r\n| Before fix | After fix |\r\n| ------------- |
------------- |\r\n| ![Screenshot 2024-10-29 at 11
53\r\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\r\n|
![Screenshot 2024-10-29 at 11
53\r\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\r\n|\r\n\r\nNotes:
this fix does not fix an issue happening in the
space-specific\r\nsearch, where Notes, Timelines and maybe other entries
are appearing\r\ntwice. That issue seems to be related to the way we are
removing then\r\nadding back links to work with the new navigation. I
looked into it but\r\ncould not find a way to fix yet, so this will be
part of a follow up
PR\r\n\r\nhttps://github.com//issues/197694","sha":"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198255","number":198255,"state":"MERGED","mergeCommit":{"sha":"3feea7bcfc398cb754efe1504928d7e62e3a4e55","message":"[8.x]
[Security Solution][Notes] - fix the notes link that is shown twice in
the search bar (#198200) (#198255)\n\n# Backport\n\nThis will backport
the following commits from `main` to `8.x`:\n- [[Security
Solution][Notes] - fix the notes link that is shown twice\nin the search
bar\n(#198200)](https://github.com/elastic/kibana/pull/198200)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Philippe\nOberti\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-30T08:33:04Z\",\"message\":\"[Security\nSolution][Notes]
- fix the notes link that is shown twice in the search\nbar
(#198200)\\n\\n## Summary\\r\\n\\r\\nThis PR fixes a minor
inconvenience\nwhere the Kibana search bar was\\r\\nshowing 2 entries
for the new Notes\nmanagement page.\\r\\n\\r\\n| Before fix | After fix
|\\r\\n| ------------- |\n------------- |\\r\\n| ![Screenshot 2024-10-29
at
11\n53\\r\\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\\r\\n|\n![Screenshot
2024-10-29 at
11\n53\\r\\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\\r\\n|\\r\\n\\r\\nNotes:\nthis
fix does not fix an issue happening in the\nspace-specific\\r\\nsearch,
where Notes, Timelines and maybe other entries\nare
appearing\\r\\ntwice. That issue seems to be related to the way we
are\nremoving then\\r\\nadding back links to work with the new
navigation. I\nlooked into it but\\r\\ncould not find a way to fix yet,
so this will be\npart of a follow
up\nPR\\r\\n\\r\\nhttps://github.com//issues/197694\",\"sha\":\"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"backport\",\"release_note:skip\",\"v9.0.0\",\"Team:Threat\nHunting:Investigations\",\"v8.16.0\"],\"title\":\"[Security
Solution][Notes] -\nfix the notes link that is shown twice in the
search\nbar\",\"number\":198200,\"url\":\"https://github.com/elastic/kibana/pull/198200\",\"mergeCommit\":{\"message\":\"[Security\nSolution][Notes]
- fix the notes link that is shown twice in the search\nbar
(#198200)\\n\\n## Summary\\r\\n\\r\\nThis PR fixes a minor
inconvenience\nwhere the Kibana search bar was\\r\\nshowing 2 entries
for the new Notes\nmanagement page.\\r\\n\\r\\n| Before fix | After fix
|\\r\\n| ------------- |\n------------- |\\r\\n| ![Screenshot 2024-10-29
at
11\n53\\r\\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\\r\\n|\n![Screenshot
2024-10-29 at
11\n53\\r\\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\\r\\n|\\r\\n\\r\\nNotes:\nthis
fix does not fix an issue happening in the\nspace-specific\\r\\nsearch,
where Notes, Timelines and maybe other entries\nare
appearing\\r\\ntwice. That issue seems to be related to the way we
are\nremoving then\\r\\nadding back links to work with the new
navigation. I\nlooked into it but\\r\\ncould not find a way to fix yet,
so this will be\npart of a follow
up\nPR\\r\\n\\r\\nhttps://github.com//issues/197694\",\"sha\":\"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198200\",\"number\":198200,\"mergeCommit\":{\"message\":\"[Security\nSolution][Notes]
- fix the notes link that is shown twice in the search\nbar
(#198200)\\n\\n## Summary\\r\\n\\r\\nThis PR fixes a minor
inconvenience\nwhere the Kibana search bar was\\r\\nshowing 2 entries
for the new Notes\nmanagement page.\\r\\n\\r\\n| Before fix | After fix
|\\r\\n| ------------- |\n------------- |\\r\\n| ![Screenshot 2024-10-29
at
11\n53\\r\\n44 AM](https://github.com/user-attachments/assets/77bd4b5a-d8d4-4f4f-8378-6aff1ec1b00b)\\r\\n|\n![Screenshot
2024-10-29 at
11\n53\\r\\n19 AM](https://github.com/user-attachments/assets/d138e307-b4ea-473b-9102-eb7e7b540bff)\\r\\n|\\r\\n\\r\\nNotes:\nthis
fix does not fix an issue happening in the\nspace-specific\\r\\nsearch,
where Notes, Timelines and maybe other entries\nare
appearing\\r\\ntwice. That issue seems to be related to the way we
are\nremoving then\\r\\nadding back links to work with the new
navigation. I\nlooked into it but\\r\\ncould not find a way to fix yet,
so this will be\npart of a follow
up\nPR\\r\\n\\r\\nhttps://github.com//issues/197694\",\"sha\":\"ac5c74a443646ec90d6b4fd86a1fce6ae28c97b3\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Philippe Oberti <[email protected]>"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants