[8.x] [Stream] Fix callout privileges (#198030) #198262
Open
+96
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes elastic#192062 This PR adds privileges checks for `Logs Explorerer` it checks for `Discover & Fleet` privileges before allowing the user access to `Logs Explorer`. Clicking on the `Logs` tab from the side nav defaults to `Stream`, as long as its not depricated, in case the user doesn't have access to `Logs Explorer` https://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf (cherry picked from commit dbfd4f0)
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
approved these changes
Oct 30, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History |
awahab07
requested changes
Oct 30, 2024
| capabilities.discover?.show && | ||
| capabilities.fleet?.read | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Suggested change
| ); | |
| ), | |
| distinctUntilChanged() | |
| ); |
// `import { map, distinctUntilChanged } from 'rxjs';`
to avoid duplicate values. Otherwise the subscription may be called multiple of times resulting in the following:
The above is observed on 8.x branch and wasn't happening on main, but would be ideal to adjust everywhere.
Also see if we need capabilities.discover?.show && capabilities.fleet?.read explicitly here as the following already includes both.
There was a problem hiding this comment.
yes the check is still needed as its the one responsible for pushing the entry to the side nav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation