[Security solution] Elastic Assistant APIs - always use performChecks
#198392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes changes around the
performChecks
function. Everywhere this was called was passingauthenticatedUser: true
andlicense: true
, so I removed those parameters and updated the code so that those checks always happen. Previously,performChecks
either returned an error response or undefined. I updated it to return either:That way when the check passes, it always returns our
AuthenticatedUser
and eliminates the need to re-run that check.Finally, I found any spot that was checking license + user on its own to use the
performChecks
function.