[Security AI Assistant] Fixed license issue for Knowledge Base resources initialization #198239

YulNaumenko · 2024-10-30T00:54:23Z

Fixed assistant resources initialization by adding license check before retry to install.
The problem was caused by fetching ELSER model from ML, which was license gated.
Fixed unnecessary client call to get KB status when the license is not min enterprise.
Unified license check and auth for all routes to use performChecks

`performChecks` cleanup

Makes changes around the performChecks function. Everywhere this was called was passing authenticatedUser: true and license: true, so we removed those parameters and updated the code so that those checks always happen. Previously, performChecks either returned an error response or undefined. We updated it to return either:

{
  isSuccess: true;
  currentUser: AuthenticatedUser;
} |
{
  isSuccess: false;
  response: IKibanaResponse;
};

That way when the check passes, it always returns our AuthenticatedUser and eliminates the need to re-run that check.

Finally, we found any spot that was checking license + user on its own to use the performChecks function.

…ces initialization

x-pack/plugins/elastic_assistant/server/ai_assistant_service/index.ts

x-pack/plugins/elastic_assistant/server/routes/anonymization_fields/bulk_actions_route.ts

x-pack/plugins/elastic_assistant/server/routes/user_conversations/find_route.ts

x-pack/plugins/elastic_assistant/server/routes/anonymization_fields/find_route.ts

x-pack/plugins/elastic_assistant/server/routes/prompts/find_route.ts

stephmilovic

Thank you so much for this fix Yuliia! I tested locally and not only do we no longer receive the toaster errors, we no longer get our "expected" error log on start up. Hooray! LGTM

kibanamachine · 2024-10-30T21:13:50Z

Starting backport for target branches: 7.17, 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11601746640

elasticmachine · 2024-10-30T21:14:11Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: d2e91ee

Failed CI Steps

Jest Tests #15

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	21.0MB	21.0MB	+221.0B

History

💔 Build #247176 failed f3e311d
💚 Build #246822 succeeded 0291f99
💔 Build #246813 failed a808b11

cc @YulNaumenko

kibanamachine · 2024-10-30T21:16:11Z

Starting backport for target branches: 8.16

https://github.com/elastic/kibana/actions/runs/11601780421

…ces initialization (elastic#198239) (cherry picked from commit ed81e43)

kibanamachine · 2024-10-30T21:19:04Z

💔 Some backports could not be created

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts
❌	8.15	Backport failed because of merge conflicts
❌	8.16	Backport failed because of merge conflicts
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 198239

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2024-10-30T21:20:42Z

💔 All backports failed

Status	Branch	Result
❌	8.16	Backport failed because of merge conflicts You might need to backport the following PRs to 8.16: - [Security Assistant] Knowledge base switch to use `semantic_text` (#197007)

Manual backport

To create the backport manually run:

node scripts/backport --pr 198239

Questions ?

Please refer to the Backport tool documentation

stephmilovic · 2024-10-30T21:27:11Z

I will backport to 8.16 once #198439 has merged

…ces initialization (elastic#198239) (cherry picked from commit ed81e43) # Conflicts: # x-pack/packages/kbn-elastic-assistant/impl/assistant/chat_send/use_chat_send.tsx # x-pack/packages/kbn-elastic-assistant/impl/knowledge_base/knowledge_base_settings.tsx # x-pack/packages/kbn-elastic-assistant/impl/knowledge_base/knowledge_base_settings_management/index.tsx # x-pack/packages/kbn-elastic-assistant/impl/knowledge_base/setup_knowledge_base_button.tsx # x-pack/plugins/elastic_assistant/server/ai_assistant_service/index.test.ts # x-pack/plugins/elastic_assistant/server/ai_assistant_service/index.ts # x-pack/plugins/elastic_assistant/server/routes/knowledge_base/entries/bulk_actions_route.ts # x-pack/plugins/elastic_assistant/server/routes/knowledge_base/entries/find_route.ts # x-pack/plugins/elastic_assistant/server/routes/request_context_factory.ts

stephmilovic · 2024-10-30T21:33:41Z

💚 All backports created successfully

Status	Branch	Result
✅	8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ces initialization (elastic#198239) (cherry picked from commit ed81e43)

stephmilovic · 2024-10-30T22:04:35Z

💚 All backports created successfully

Status	Branch	Result
✅	8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…resources initialization (#198239) (#198447) # Backport This will backport the following commits from `main` to `8.x`: - [[Security AI Assistant] Fixed license issue for Knowledge Base resources initialization (#198239)](#198239)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Yuliia Naumenko <[email protected]>

… resources initialization (#198239) (#198451) # Backport This will backport the following commits from `main` to `8.16`: - [[Security AI Assistant] Fixed license issue for Knowledge Base resources initialization (#198239)](#198239)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Yuliia Naumenko <[email protected]>

[Security AI Assistant] Fixed license issue for Knowledge Base resour…

a808b11

…ces initialization

YulNaumenko added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:all-open Backport to all branches that could still receive a release v8.16.0 labels Oct 30, 2024

YulNaumenko self-assigned this Oct 30, 2024

YulNaumenko requested a review from a team as a code owner October 30, 2024 00:54

YulNaumenko added 3 commits October 29, 2024 20:31

fixed tests

f300e09

Merge branch 'main' into security-assistant-kb-license-check

bab52aa

-

0291f99

stephmilovic reviewed Oct 30, 2024

View reviewed changes

x-pack/plugins/elastic_assistant/server/ai_assistant_service/index.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Oct 30, 2024

View reviewed changes

x-pack/plugins/elastic_assistant/server/routes/anonymization_fields/bulk_actions_route.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Oct 30, 2024

View reviewed changes

x-pack/plugins/elastic_assistant/server/routes/user_conversations/find_route.ts Show resolved Hide resolved

stephmilovic added 6 commits October 30, 2024 09:20

initial

94c10df

couple more

1bd64de

test fix

c55e216

merge in perform_checks

e27f8c0

one more

18dd9d5

rm null user

19522e1

stephmilovic mentioned this pull request Oct 30, 2024

[Security solution] Elastic Assistant APIs - always use performChecks #198392

Closed

stephmilovic reviewed Oct 30, 2024

View reviewed changes

x-pack/plugins/elastic_assistant/server/routes/anonymization_fields/find_route.ts Show resolved Hide resolved

stephmilovic reviewed Oct 30, 2024

View reviewed changes

x-pack/plugins/elastic_assistant/server/routes/prompts/find_route.ts Show resolved Hide resolved

stephmilovic added 2 commits October 30, 2024 10:17

more performChecks

b3a182a

move license check up

f3e311d

stephmilovic approved these changes Oct 30, 2024

View reviewed changes

This was referenced Oct 30, 2024

[Security solution] assistantKnowledgeBaseByDefault flag removed #198180

Draft

[Security solution] assistantKnowledgeBaseByDefault flag defaults to true #198178

Open

YulNaumenko enabled auto-merge (squash) October 30, 2024 16:35

rm unused var and fix test

6603b7e

stephmilovic added 2 commits October 30, 2024 12:05

rm ln

a3f6aed

Merge branch 'main' into security-assistant-kb-license-check

d2e91ee

stephmilovic disabled auto-merge October 30, 2024 20:26

stephmilovic enabled auto-merge (squash) October 30, 2024 21:13

stephmilovic merged commit ed81e43 into elastic:main Oct 30, 2024
38 checks passed

stephmilovic added backport:version Backport to applied version labels v8.17.0 and removed backport:all-open Backport to all branches that could still receive a release labels Oct 30, 2024

stephmilovic added the v8.15.4 label Oct 30, 2024

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2024

[Security AI Assistant] Fixed license issue for Knowledge Base resour…

9e20bc2

…ces initialization (elastic#198239) (cherry picked from commit ed81e43)

kibanamachine mentioned this pull request Oct 30, 2024

[8.x] [Security AI Assistant] Fixed license issue for Knowledge Base resources initialization (#198239) #198447

Merged

stephmilovic mentioned this pull request Oct 30, 2024

[8.15] [Security AI Assistant] Fixed license issue for Knowledge Base resources initialization (#198239) #198449

Open

stephmilovic pushed a commit to stephmilovic/kibana that referenced this pull request Oct 30, 2024

[Security AI Assistant] Fixed license issue for Knowledge Base resour…

e81d234

…ces initialization (elastic#198239) (cherry picked from commit ed81e43)

stephmilovic mentioned this pull request Oct 30, 2024

[8.16] [Security AI Assistant] Fixed license issue for Knowledge Base resources initialization (#198239) #198451

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security AI Assistant] Fixed license issue for Knowledge Base resources initialization #198239

[Security AI Assistant] Fixed license issue for Knowledge Base resources initialization #198239

YulNaumenko commented Oct 30, 2024 •

edited by kibanamachine

Loading

stephmilovic left a comment

kibanamachine commented Oct 30, 2024

elasticmachine commented Oct 30, 2024

kibanamachine commented Oct 30, 2024

kibanamachine commented Oct 30, 2024

kibanamachine commented Oct 30, 2024

stephmilovic commented Oct 30, 2024

stephmilovic commented Oct 30, 2024

stephmilovic commented Oct 30, 2024

[Security AI Assistant] Fixed license issue for Knowledge Base resources initialization #198239

[Security AI Assistant] Fixed license issue for Knowledge Base resources initialization #198239

Conversation

YulNaumenko commented Oct 30, 2024 • edited by kibanamachine Loading

performChecks cleanup

stephmilovic left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 30, 2024

elasticmachine commented Oct 30, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

History

kibanamachine commented Oct 30, 2024

kibanamachine commented Oct 30, 2024

💔 Some backports could not be created

Manual backport

Questions ?

kibanamachine commented Oct 30, 2024

💔 All backports failed

Manual backport

Questions ?

stephmilovic commented Oct 30, 2024

stephmilovic commented Oct 30, 2024

💚 All backports created successfully

Questions ?

stephmilovic commented Oct 30, 2024

💚 All backports created successfully

Questions ?

YulNaumenko commented Oct 30, 2024 •

edited by kibanamachine

Loading

`performChecks` cleanup