Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Composer: text looses formatting after editing a markdown message or editing a reply message #8638

Closed
wants to merge 4 commits into from

Conversation

Luka5W
Copy link

@Luka5W Luka5W commented Sep 2, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Reverted some changes made in #8377

Motivation and context

Fixes #8602
Fixes #8612

Screenshots / GIFs

The screenshots were made immediately after long-tapping on the message to edit and selecting edit:

Before After
Screenshot_20230902_013913 Screenshot_20230902_013050

Tests

See screenshots

Tested devices

  • Physical
  • Emulator
  • OS version(s): Pixel_3a_API_34_extension_level_7_x86_64

Checklist

@@ -0,0 +1 @@
User pills don't get lost at message editing anymore
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pills, or polls?

Copy link
Author

@Luka5W Luka5W Sep 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well... i have no idea. i just stole it from here :P maybe the markdown formatting marks are called 'pills' internally? but im sure, both PRs dont affect polls in any way^^

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pludi do you have a better message for the changelog or is anyone working on merging on the PR? the code is not reviewed yet

@pludi
Copy link

pludi commented Oct 10, 2023

Sorry, I didn't know that by just adding a comment I've been set as reviewer…

@ganfra
Copy link
Member

ganfra commented Dec 20, 2023

Replaced by #8716

Thanks for the effort, and sorry it has been so long to be there.

@ganfra ganfra closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants