-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bunch of issues related to edition and reply #5969 #8716
Conversation
I tried using the RTE to edit a message in this order:
I think the MD text should be displayed there instead of the HTML, and in any case the mx-reply should be gone. |
@jmartinesp I understand your point, but I'm not sure we should spend more time on this edge case where the Text formatting is disabled between 2 editions of the same message. I will let you decide about this with the Android team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the issue mentioned above, but it was there before and will required a different fix than this, but other than that it LGTM, just a question about detecting the mx-reply
tags.
if (closingTagIndex != -1) { | ||
return repliedBody.substring(closingTagIndex + "</mx-reply>".length).trim() | ||
return repliedBody.substring(closingTagIndex + MX_REPLY_END_TAG.length).trim() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we get a </ mx-reply>
tag, with one or several whitespaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope not, I kept the same tags than before.
Ok, lets iterate later with the other issues. |
e83768a
to
2ada4c8
Compare
Quality Gate failedFailed conditions 4.5% Coverage on New Code (required ≥ 80%) |
In Element Android v1.6.10 I cannot reply to any message. The option simply doesn't exist. |
This fixes #5969
It replaces this PR even if the fix is not the same.
The downside is, it doesn't fix the edition of markdown, but at least we can keep the permalink...