Sync code snippet with selected icon #29
Conversation
Wrap icons in toggle buttons, track the selected one and update example code snippet accordingly. This also fixes an issue with incorrect snippet for symbolic only icons or those without size 24px.
|
Sorry for the linting errors, I'll fix them tonight. |
Add missing white-space and convert snippet template into a multi-line string.
|
The code itself seems fine, but I do wonder about the styling. Is there a way to easily have the buttons be a uniform width? For example when there is only one icon in a group, it taking up the full width doesn't feel nice, to me anyway. Maybe someone from @elementary/ux can weigh in. |
Limit size of toggle buttons for selecting icons by wrapping them inside a Adw.Clamp widget with maximum size of 128. Introduce dependency on libadwaita-1, which can be removed after Granite issue #623 is resolved.
|
Thanks for the feedback @zeebok! Indeed, horizontally expanded buttons look bad. I tried playing around with them a bit, and I think I made some progress. I added a size constraint using the Adw.Clamp. I had to introduce a dependency on LibAdwaita for that, but we will be able to remove it once Granite issue #623 is resolved. Here are a few examples of the new look:
This is what it looks like in full screen layout, when the app has mode horizontal space to work with:
|
|
This is definitely better and am okay with it. I think before any final thumbs-up for merging it should get the ok from @elementary/ux or at least @danirabbit for the styling since she had the original vision for the app. |
|
Ah, yes, using Gtk.FlowBox makes much more sense than the shenanigans I was up to here. I'll close this PR in favor of #32 |
Resolves #12
I wrapped icons in toggle buttons, tracked the selected one and updated example code snippet accordingly. This also fixes an issue with incorrect snippet for symbolic only icons or those without size 24px, for which the static snippet doesn't work.
Example of using it:
dynamic-snippet-showcase.webm