-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snippet based on selection #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Clicking on a symbolic icon child after a color icon results in two selected items. Even though one is unfocused this still looks wrong/confusing to me.
-
If the icon name is changed after selecting an icon size and type, the icon size and type reverts to the default of 24px color. I think the selected size and type should persist (if available).
-
After selecting an icon size for "emblem-documents" then change to a different icon name the icon sizes are no longer selectable. This can happen with other icons but the exact reason is unclear - possibly due to unavailable color icons?
-
Emote icons do not have a "24px" version; nevertheless the code snippet is for 24px
1, 3, and 4. Fixed! |
This looks good to me, and addresses the issues Jeremy spotted. If you like I can approve. |
Haven't heard back in a couple weeks and someone else confirmed this fixed raised issues
Fixes #12