Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional ServiceProvider.SigningCertificate #26

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Optional ServiceProvider.SigningCertificate #26

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a444961
Made ServiceProvider.SigningCertificate Optional
samunro Apr 5, 2019
d6afeb5
Removed blank line at the end of file.
samunro Apr 5, 2019
fffb8da
Default to RedirectAfterLogin in SamlAuthenticationHandler.ApplyRespo…
samunro Apr 9, 2019
e9b9601
Merge remote-tracking branch 'origin/patch-1'
samunro Nov 27, 2020
befc1ac
There were errors with Azure AD. The metadata included RoleDescriptor…
samunro Aug 31, 2021
fedab88
There were problems with checking the signature on an assertion becau…
samunro Aug 31, 2021
c13ec71
Changed version numbers so that I could create new NuGet package vers…
samunro Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Owin.Security.Saml/SamlMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ private string AuthnRequestForIdp(IdentityProvider identityProvider, Saml20Authn

var redirectBuilder = new HttpRedirectBindingBuilder
{
SigningKey = config.ServiceProvider.SigningCertificate.PrivateKey,
SigningKey = config.ServiceProvider.SigningCertificate?.PrivateKey,
Request = request.GetXml().OuterXml
};
if (context.Authentication != null &&
Expand Down Expand Up @@ -229,4 +229,4 @@ public override string BuildFormPost()
return base.BuildFormPost(); // See Saml20SignonHandler.cs, line 591 (post binding)
}
}
}
}
Copy link
Author

@samunro samunro Apr 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where the newline came from. I even tried to reverse the change but I think that the web interface might add it in by default.