Add ssrc attributes to the SDP #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
force-pushed
the
ssrc
branch
2 times, most recently
from
82d0d65 to
f03b4c2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
- Coverage 84.56% 84.52% -0.05%
==========================================
Files 49 49
Lines 2482 2507 +25
==========================================
+ Hits 2099 2119 +20
- Misses 383 388 +5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mickel8
commented
Jan 15, 2025
Comment on lines
+31
to
+36
| |> Enum.map(fn seq_no -> | ||
| {seq_no, Map.get(responder.packets, rem(seq_no, @max_packets))} | ||
| end) | ||
| |> Enum.filter(fn {seq_no, packet} -> | ||
| packet != nil and packet.sequence_number == seq_no | ||
| end) |
sgfn
reviewed
Jan 16, 2025
Comment on lines
+6
to
+8
| {:ok, pc} = PeerConnection.start_link() | ||
| @config PeerConnection.get_configuration(pc) | ||
| :ok = PeerConnection.close(pc) |
There was a problem hiding this comment.
Yeap, but acutally I am curious what is the process, peer connection will be linked to 🤔
sgfn
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some implementations still rely on ssrc attributes in SDP offer/answer when demuxing incoming RTP packets (e.g. Pion). While including a=ssrc attribute in the SDP is obsoleted and we should demux by mid, including ssrc is still correct and supported by web browsers.
This PR adds ssrc attributes to the SDP offer/answer when a transceiver is sendonly or sendrecv.
A couple of notes:
a=ssrc:1234attribute, it should also always has cname attr i.e.a=ssrc:1234 cname:qW34eced(RFC 5567)