Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ssrc attributes to the SDP #185

Merged
merged 3 commits into from
Jan 17, 2025

Refactor generate_ssrcs and get_ssrc_attrs

fadedd9
Select commit
Loading
Failed to load commit list.
Merged

Add ssrc attributes to the SDP #185

Refactor generate_ssrcs and get_ssrc_attrs
fadedd9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

84.52% (-0.05%) compared to 1d09628, passed because coverage increased by 0.13% when compared to adjusted base (84.38%)

View this Pull Request on Codecov

84.52% (-0.05%) compared to 1d09628, passed because coverage increased by 0.13% when compared to adjusted base (84.38%)

Details

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.52%. Comparing base (1d09628) to head (fadedd9).

Files with missing lines Patch % Lines
lib/ex_webrtc/rtp_sender.ex 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   84.56%   84.52%   -0.05%     
==========================================
  Files          49       49              
  Lines        2482     2507      +25     
==========================================
+ Hits         2099     2119      +20     
- Misses        383      388       +5     
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection.ex 85.31% <100.00%> (-0.63%) ⬇️
lib/ex_webrtc/rtp_sender/nack_responder.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp_transceiver.ex 90.75% <100.00%> (-0.21%) ⬇️
lib/ex_webrtc/rtp_sender.ex 92.85% <95.65%> (+1.05%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d09628...fadedd9. Read the comment docs.