Modify the metaclasses to ensure compatibility with Python 3.13 and earlier versions. #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
junkmd
force-pushed
the
py313_compatible_metacls
branch
from
df193d3
to
3e67459
Compare
to `_coclass_meta.__new__`.
to `_cominterface_meta.__new__`.
junkmd
force-pushed
the
py313_compatible_metacls
branch
from
3e67459
to
c35ab20
Compare
v01d-gh
approved these changes
Oct 19, 2024
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Oct 19, 2024
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #618.
To support Python 3.13, changes are required in the codebase of the
_coclass_meta,_cominterface_meta, and_make_safearray_type.This is due to changes in the implementation of
ctypesstarting from Python 3.13, which introduced breaking changes to metaclass initialization.I posted about this in python/cpython#124520 and arrived at this implementation after receiving advice from the
ctypesmaintainer.Please see also https://docs.python.org/3.13/whatsnew/3.13.html#ctypes.
I would like to hear from the community and other maintainers whether the codebases are reasonable and the comments will be helpful for future readers.
Any feedback is welcome.
If there are no objections, I plan to merge this after October 21st and release it as
comtypes==1.4.8.