Add exist method on BlobStoreRepository #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpaturet
force-pushed
the
add_exist_blob_method
branch
from
e9e8cf4 to
61a2d08
Compare
vpaturet
force-pushed
the
add_exist_blob_method
branch
from
61a2d08 to
045a451
Compare
|
esuomi
approved these changes
Dec 3, 2024
Comment on lines
+59
to
+61
| } catch (NoSuchKeyException e) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Looks fine to me 👍 This is a bit of a wart in AWS S3 client - using exceptions for flow control, that is - so handling it like this is fine.
Of course returning an Optional<InputStream> could express the semantics of the return value better, but the current implementation and the other changes in the PR are less intrusive and won't cause issues downstream, so I'm fine with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to check if a blob exists in the repository.
A default implementation is provided that retrieves the object and test for nullity.
This requires clarifying the behavior of the method
BlobStoreRepository.getBlob()when the requested blob does not exist.The S3 implementation is adapted to return
nullwhen the object does not exist, instead of throwing an exception.