fix: internal preview build iOS #1093
Conversation
|
Warning Rate limit exceeded@thierryskoda has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes include the deletion of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
thierryskoda
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- .github/workflows/testflight.yml (0 hunks)
- eas.json (1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/testflight.yml
🧰 Additional context used
🪛 Biome
eas.json
[error] 85-85: expected
,but instead foundØRemove Ø
(parse)
[error] 86-86: expected
:but instead found}Remove }
(parse)
eas.json
Outdated
| }Ø | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Fix JSON syntax errors
There are syntax errors in the JSON structure that need to be addressed:
- Remove the unexpected
Øcharacter - Fix the JSON structure
Apply this diff to fix the syntax:
"preview": {
"android": {
"track": "internal"
},
"ios": {
"ascAppId": "6478027666"
}
- }Ø
- }
-}
+ }
+ }
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| }Ø | |
| } | |
| } | |
| } | |
| "preview": { | |
| "android": { | |
| "track": "internal" | |
| }, | |
| "ios": { | |
| "ascAppId": "6478027666" | |
| } | |
| } | |
| } | |
| } |
🧰 Tools
🪛 Biome
[error] 85-85: expected
,but instead foundØRemove Ø
(parse)
[error] 86-86: expected
:but instead found}Remove }
(parse)
| }, | ||
| "ios": { | ||
| "ascAppId": "1658819514" | ||
| } | ||
| }, | ||
| "production-android": { | ||
| "extends": "production" | ||
| }, | ||
| "preview": { | ||
| "android": { | ||
| "track": "internal" | ||
| } | ||
| }, | ||
| "preview-ios": { | ||
| "extends": "production", | ||
| }, | ||
| "ios": { | ||
| "ascAppId": "6478027666" | ||
| } |
There was a problem hiding this comment.
💡 Codebase verification
Based on the gathered information, I can now provide a final response:
Deployment workflow changes confirmed - action required
The changes indicate a transition from GitHub Actions TestFlight workflow to EAS Submit:
- TestFlight GitHub Action has been removed
- EAS Submit configuration has been added with correct App Store Connect IDs:
- Production: 1658819514
- Preview: 6478027666
- However, no deployment documentation updates were found to reflect this change
Action items:
- Documentation needs to be updated to reflect the new EAS Submit deployment process
- Team should be notified about the deployment workflow change
- Consider creating a deployment guide for the new EAS Submit process
🔗 Analysis chain
Verify App Store Connect IDs and deployment strategy
The changes indicate a shift from GitHub Actions TestFlight workflow to EAS Submit for iOS deployments. Please verify:
- The App Store Connect IDs are correct:
- Production:
1658819514 - Preview:
6478027666
- Production:
- The team is aware of the deployment process change
- Documentation has been updated to reflect the new deployment workflow
Let's verify if these are the correct App Store IDs:
Let me gather more information about the deployment workflow changes to verify if documentation has been updated.
Let me search for documentation and deployment workflow changes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any references to these App Store IDs in the codebase
# to ensure consistency and verify their usage
echo "Searching for Production App Store ID..."
rg -i "1658819514"
echo "Searching for Preview App Store ID..."
rg -i "6478027666"
# Also check for any remaining TestFlight references that might need updating
echo "Checking for remaining TestFlight references..."
rg -i "testflight" -g '!.git'
Length of output: 523
Script:
#!/bin/bash
# Check for documentation updates related to deployment changes
echo "Searching for deployment-related documentation..."
fd -e md -e mdx | xargs rg -i -l "deploy|eas submit|app store|testflight"
# Check for removed GitHub Actions workflow
echo "Checking for TestFlight GitHub Action removal..."
fd -g '.github/workflows/*.yml' | xargs rg -i "testflight|ios|app store"
# Check for EAS Submit configuration
echo "Checking for EAS Submit configuration..."
rg -i "eas submit|submit-type" -g 'eas*'
Length of output: 181279
Script:
#!/bin/bash
# Search for documentation files and deployment related changes
echo "Searching for deployment documentation..."
fd -e md -e mdx | xargs rg -l "deployment|submit|testflight|app store"
# Check for removed TestFlight workflow file
echo "Checking for removed TestFlight workflow file..."
git log --diff-filter=D -p | rg "testflight|ios.*workflow"
# Check for EAS Submit related changes in app.json/app.config.js
echo "Checking EAS Submit config..."
rg "submit|ascAppId" app.config.ts app.json eas.json
Length of output: 2355
|
@thierryskoda going to close this out since it should be resolved with the other changes |
@alexrisch this is a small fix to fix what happened here with my internal build on iOS https://github.com/ephemeraHQ/converse-app/actions/runs/11499980582/job/32011918449
I think there's a lot of clean up that could be done for deployment but didn't want to put more time now until you think it could be a huge gain.
I know you also have some work in progress on that.
Summary by CodeRabbit
eas.jsonconfiguration by removingextendsproperties for iOS and Android configurations, while adding specificascAppIdvalues for iOS.