Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: internal preview build iOS #1093

Closed
wants to merge 3 commits into from
Closed

fix: internal preview build iOS #1093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a7c42c
remove testflight action
thierryskoda Oct 24, 2024
0593194
fix eas
thierryskoda Oct 24, 2024
c111761
oops
thierryskoda Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions .github/workflows/testflight.yml
View file
Open in desktop

This file was deleted.

16 changes: 2 additions & 14 deletions eas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,30 +70,18 @@
"production": {
"android": {
"track": "internal"
}
},
"production-ios": {
"extends": "production",
},
"ios": {
"ascAppId": "1658819514"
}
},
"production-android": {
"extends": "production"
},
"preview": {
"android": {
"track": "internal"
}
},
"preview-ios": {
"extends": "production",
},
"ios": {
"ascAppId": "6478027666"
}
Comment on lines +73 to 84
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Based on the gathered information, I can now provide a final response:

Deployment workflow changes confirmed - action required

The changes indicate a transition from GitHub Actions TestFlight workflow to EAS Submit:

  1. TestFlight GitHub Action has been removed
  2. EAS Submit configuration has been added with correct App Store Connect IDs:
    • Production: 1658819514
    • Preview: 6478027666
  3. However, no deployment documentation updates were found to reflect this change

Action items:

  • Documentation needs to be updated to reflect the new EAS Submit deployment process
  • Team should be notified about the deployment workflow change
  • Consider creating a deployment guide for the new EAS Submit process
🔗 Analysis chain

Verify App Store Connect IDs and deployment strategy

The changes indicate a shift from GitHub Actions TestFlight workflow to EAS Submit for iOS deployments. Please verify:

  1. The App Store Connect IDs are correct:
    • Production: 1658819514
    • Preview: 6478027666
  2. The team is aware of the deployment process change
  3. Documentation has been updated to reflect the new deployment workflow

Let's verify if these are the correct App Store IDs:

Let me gather more information about the deployment workflow changes to verify if documentation has been updated.

Let me search for documentation and deployment workflow changes.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any references to these App Store IDs in the codebase
# to ensure consistency and verify their usage

echo "Searching for Production App Store ID..."
rg -i "1658819514"

echo "Searching for Preview App Store ID..."
rg -i "6478027666"

# Also check for any remaining TestFlight references that might need updating
echo "Checking for remaining TestFlight references..."
rg -i "testflight" -g '!.git'

Length of output: 523

Script:

#!/bin/bash
# Check for documentation updates related to deployment changes
echo "Searching for deployment-related documentation..."
fd -e md -e mdx | xargs rg -i -l "deploy|eas submit|app store|testflight"

# Check for removed GitHub Actions workflow
echo "Checking for TestFlight GitHub Action removal..."
fd -g '.github/workflows/*.yml' | xargs rg -i "testflight|ios|app store"

# Check for EAS Submit configuration
echo "Checking for EAS Submit configuration..."
rg -i "eas submit|submit-type" -g 'eas*'

Length of output: 181279

Script:

#!/bin/bash
# Search for documentation files and deployment related changes
echo "Searching for deployment documentation..."
fd -e md -e mdx | xargs rg -l "deployment|submit|testflight|app store"

# Check for removed TestFlight workflow file
echo "Checking for removed TestFlight workflow file..."
git log --diff-filter=D -p | rg "testflight|ios.*workflow"

# Check for EAS Submit related changes in app.json/app.config.js
echo "Checking EAS Submit config..."
rg "submit|ascAppId" app.config.ts app.json eas.json

Length of output: 2355

},
"preview-android": {
"extends": "production"
}
}
}
Loading