💥 Add collisions methods #9
Conversation
BoxVsBox BoxVsSphere SphereVsBox SphereVsSphere
…methods 🧑🚀 Physics engine utils: movement methods
…ollisions-methods
negative size object are now consider object with a positive size but in the opposite direction
landryarki
requested review from
RenardFute,
6im0n,
AubaneNourry and
Marius-P1
rename from "ShapeVsShape" to "ShapeCollideShape"
There was a problem hiding this comment.
I agree with the functions but not sure about the use,
We will add components like RectCollider, RoundCollider that will use these functions in their inner logic and will refer to a Transform Component to get the position / dimensions of these geometrics elements?
Update CI and good for me :)
There was a problem hiding this comment.
I'm not going to approve or disapprove this.
I believe what you did is working, there is no problem with that but it looks like your system is really 'rigid'. What I mean by that is, that whenever we will want to add another X collide with Y we will need to update Physics::Collision class.
My idea would have been to make an ICollider interfaces that would provide some way of mathematically know wether it's colliding with something.
The result code in Physics::Collision would look like this
bool isColliding(const ICollider &a, const IColllider &b) {
const aEquation = a.getCollisionEquation();
const bEquation = b.getCollisionEquation();
const mixed = // some math stuff
return // math result
}This is all theoretical but I believe, if possible, a system like this would be better.
Maybe SDF ??
…ollisions-methods
landryarki
force-pushed
the
feature/epi-46-collisions-methods
branch
from
de305d7
to
5734f35
Compare
ICollider, box and sphere are now on a fille Collider.hpp/cpp
…ollisions-methods
remove collider cpp since it was basically the code for boxes and shperes but keeped the hpp with the interfact og a collider
…ollisions-methods
collisions methods to collide boxes and spheres