Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite collision detection interface #4987

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Rewrite collision detection interface #4987

merged 4 commits into from
Sep 9, 2024

Conversation

1234somesh
Copy link
Contributor

@1234somesh 1234somesh commented Aug 23, 2024 •
edited by jngrad
Loading

Fixes #4483

Description of changes:

  • split feature into a collision detection class and several protocol classes, one for each binding mode

@jngrad jngrad force-pushed the python branch 3 times, most recently from 148a71d to 96b8f35 Compare September 3, 2024 15:29
@jngrad @1234somesh @mebrito
Rewrite collision detection feature
1ce7175 
Co-authored-by: Somesh Kurahatti <[email protected]>
Co-authored-by: Mariano Brito <[email protected]>
@jngrad jngrad changed the title refactoring collision detection interface Rewrite collision detection interface Sep 3, 2024
@jngrad jngrad added this to the ESPResSo 4.3.0 milestone Sep 3, 2024
@jngrad
Copy link
Member

jngrad commented Sep 4, 2024

This PR is currently blocking #4974.

@jngrad jngrad requested a review from mebrito September 4, 2024 13:46
mebrito
mebrito suggested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@mebrito mebrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the suggestions are related to readability. But there are some minor changes needed, especially in the documentation.

doc/sphinx/advanced_methods.rst Outdated Show resolved Hide resolved
doc/sphinx/advanced_methods.rst Outdated Show resolved Hide resolved
doc/sphinx/advanced_methods.rst Outdated Show resolved Hide resolved
doc/sphinx/advanced_methods.rst Show resolved Hide resolved
doc/sphinx/advanced_methods.rst Show resolved Hide resolved
src/script_interface/collision_detection/GlueToSurface.hpp Show resolved Hide resolved
src/script_interface/collision_detection/Off.hpp Show resolved Hide resolved
src/script_interface/collision_detection/BindCenters.hpp Show resolved Hide resolved
src/script_interface/collision_detection/BindAtPointOfCollision.hpp Show resolved Hide resolved
src/script_interface/collision_detection/BindAtPointOfCollision.hpp Show resolved Hide resolved
@jngrad jngrad self-assigned this Sep 6, 2024
@jngrad @mebrito
Apply code review suggestions
8f432a7 
Co-authored-by: Mariano Brito <[email protected]>
@jngrad jngrad requested review from mebrito and reinaual September 6, 2024 16:23
@jngrad @reinaual
Apply code review suggestions
bb8014c 
Co-authored-by: Alexander Reinauer <[email protected]>
@jngrad jngrad requested a review from reinaual September 9, 2024 13:04
@jngrad jngrad added the automerge Merge with kodiak label Sep 9, 2024
@kodiakhq kodiakhq bot merged commit a92c634 into espressomd:python Sep 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad left review comments

@mebrito mebrito mebrito approved these changes

@reinaual reinaual reinaual approved these changes

Assignees

@jngrad jngrad

Labels
ApiChange automerge Merge with kodiak Improvement ScriptInterface
Projects
None yet
Milestone
ESPResSo 4.3.0
Development

Successfully merging this pull request may close these issues.

Rewrite collision detection interface
4 participants
@1234somesh @jngrad @reinaual @mebrito