Merge branch 'main' into fix-spearbit/fee-recipient-max-func

.github/CODEOWNERS

@@ -0,0 +1 @@
+* @haythemsellami

src/EulerEarn.sol

@@ -86,6 +86,7 @@ contract EulerEarn is Dispatch, AccessControlEnumerableUpgradeable, IEulerEarn {
         _setRoleAdmin(Constants.STRATEGY_OPERATOR, Constants.STRATEGY_OPERATOR_ADMIN);
         _setRoleAdmin(Constants.EULER_EARN_MANAGER, Constants.EULER_EARN_MANAGER_ADMIN);
         _setRoleAdmin(Constants.WITHDRAWAL_QUEUE_MANAGER, Constants.WITHDRAWAL_QUEUE_MANAGER_ADMIN);
+        _setRoleAdmin(Constants.REBALANCER, Constants.REBALANCER_ADMIN);
     }
 
     /// @dev Overriding grantRole().

src/lib/EventsLib.sol

@@ -10,7 +10,7 @@ library EventsLib {
     /// @dev EulerEarnVault.sol events
     event AccruePerformanceFee(address indexed feeRecipient, uint256 yield, uint256 feeShares);
     event ExecuteHarvest(address indexed strategy, uint256 eulerEarnAssetsAmount, uint256 strategyAllocatedAmount);
-    event Harvest(uint256 totalAllocated, uint256 totlaYield, uint256 totalLoss);
+    event Harvest(uint256 totalAllocated, uint256 totalYield, uint256 totalLoss);
     event Deposit(address indexed sender, address indexed owner, uint256 assets, uint256 shares);
     event Rebalance(address indexed strategy, uint256 amountToRebalance, bool isDeposit);
 

src/module/EulerEarnVault.sol

@@ -40,7 +40,7 @@ abstract contract EulerEarnVaultModule is ERC4626Upgradeable, ERC20VotesUpgradea
     using SafePermit2Lib for IERC20;
 
     /// @notice Rebalance strategies allocation.
-    /// @dev The order of the strategies array impact the rebalance. Ideally the staretgies that will be withdrawn from are at the beginning of the array.
+    /// @dev The order of the strategies array impact the rebalance. Ideally the strategies that will be withdrawn from are at the beginning of the array.
     ///      All strategies in withdrawal queue will be harvested.
     /// @param _strategies Strategies addresses.
     function rebalance(address[] calldata _strategies) public virtual nonReentrant {
@@ -253,15 +253,15 @@ abstract contract EulerEarnVaultModule is ERC4626Upgradeable, ERC20VotesUpgradea
     }
 
     /// @notice Convert to an approximation of the amount of shares that the Vault would exchange for the amount of assets provided.
-    /// @dev This function will just return an approximation and not an exact amount as it does not simulate a harvest, and it should be used as a share price oracle.
+    /// @dev This function will just return an approximation and not an exact amount as it does not simulate a harvest, and it should not be used as a share price oracle.
     /// @param _assets Amount of assets.
     /// @return Amount of shares.
     function convertToShares(uint256 _assets) public view virtual override nonReentrantView returns (uint256) {
         return _convertToShares(_assets, Math.Rounding.Floor);
     }
 
     /// @notice Convert to an apprximation of the amount of assets that the Vault would exchange for the amount of shares provided.
-    /// @dev This function will just return an approximation and not an exact amount as it does not simulate a harvest, and it should be used as a share price oracle.
+    /// @dev This function will just return an approximation and not an exact amount as it does not simulate a harvest, and it should not be used as a share price oracle.
     /// @param _shares Amount of shares.
     /// @return Amount of assets.
     function convertToAssets(uint256 _shares) public view virtual override nonReentrantView returns (uint256) {

test/common/EulerEarnBase.t.sol

@@ -116,6 +116,7 @@ contract EulerEarnBase is EVaultTestBase {
         assertEq(cashReserve.allocationPoints, CASH_RESERVE_ALLOCATION_POINTS);
         assertEq(cashReserve.status == IEulerEarn.StrategyStatus.Active, true);
 
+        assertEq(eulerEulerEarnVault.getRoleAdmin(ConstantsLib.GUARDIAN), ConstantsLib.GUARDIAN_ADMIN);
         assertEq(eulerEulerEarnVault.getRoleAdmin(ConstantsLib.STRATEGY_OPERATOR), ConstantsLib.STRATEGY_OPERATOR_ADMIN);
         assertEq(
             eulerEulerEarnVault.getRoleAdmin(ConstantsLib.EULER_EARN_MANAGER), ConstantsLib.EULER_EARN_MANAGER_ADMIN
@@ -124,12 +125,15 @@ contract EulerEarnBase is EVaultTestBase {
             eulerEulerEarnVault.getRoleAdmin(ConstantsLib.WITHDRAWAL_QUEUE_MANAGER),
             ConstantsLib.WITHDRAWAL_QUEUE_MANAGER_ADMIN
         );
+        assertEq(eulerEulerEarnVault.getRoleAdmin(ConstantsLib.REBALANCER), ConstantsLib.REBALANCER_ADMIN);
 
+        assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.GUARDIAN_ADMIN, deployer));
         assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.STRATEGY_OPERATOR_ADMIN, deployer));
         assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.EULER_EARN_MANAGER_ADMIN, deployer));
         assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.WITHDRAWAL_QUEUE_MANAGER_ADMIN, deployer));
         assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.REBALANCER_ADMIN, deployer));
 
+        assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.GUARDIAN, manager));
         assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.STRATEGY_OPERATOR, manager));
         assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.EULER_EARN_MANAGER, manager));
         assertTrue(eulerEulerEarnVault.hasRole(ConstantsLib.WITHDRAWAL_QUEUE_MANAGER, manager));