add slither

.github/workflows/slither.yml

@@ -0,0 +1,31 @@
+name: Slither Analysis
+
+on:
+    push:
+        branches:
+            - main
+    pull_request:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  analyze:
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v3
+
+    - name: Run Slither
+      uses: crytic/[email protected]
+      id: slither
+      with:
+        node-version: 16
+        sarif: results.sarif
+        fail-on: high
+      continue-on-error : true

slither.config.json

@@ -0,0 +1,21 @@
+{
+    "detectors_to_run": "abiencoderv2-array,array-by-reference,encode-packed-collision,incorrect-shift,name-reused,shadowing-state,uninitialized-state,uninitialized-storage,unprotected-upgrade,incorrect-return,storage-array,shadowing-abstract,write-after-write,constant-function-state,unused-return,variable-scope,redundant-statements,unimplemented-functions,unused-import,unused-state,dead-code,constable-states,external-function,immutable-states,var-read-using-this",
+    "exclude_informational": false,
+    "exclude_low": false,
+    "exclude_medium": false,
+    "exclude_high": false,
+    "disable_color": false,
+    "solc_remaps": [
+        "ds-test/=lib/ethereum-vault-connector/lib/forge-std/lib/ds-test/src/",
+        "erc4626-tests/=lib/ethereum-vault-connector/lib/openzeppelin-contracts/lib/erc4626-tests/",
+        "ethereum-vault-connector/=lib/ethereum-vault-connector/src/",
+        "forge-std/=lib/forge-std/src/",
+        "evk/=lib/euler-vault-kit/",
+        "reward-streams=lib/reward-streams/src",
+        "openzeppelin-contracts/=lib/reward-streams/lib/openzeppelin-contracts/contracts",
+        "@openzeppelin/=lib/openzeppelin-contracts/",
+        "@openzeppelin-upgradeable/=lib/openzeppelin-contracts-upgradeable/contracts/",
+        "crytic-properties/=lib/properties/contracts/"
+    ],
+    "compile_force_framework": "foundry"
+}

src/core/lib/ErrorsLib.sol

@@ -3,7 +3,6 @@ pragma solidity ^0.8.0;
 
 library ErrorsLib {
     error Reentrancy();
-    error ArrayLengthMismatch();
     error InitialAllocationPointsZero();
     error NegativeYield();
     error InactiveStrategy();