Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLM docs: OpenAI model update #13119

Merged
merged 3 commits into from
Nov 8, 2023
Merged

LLM docs: OpenAI model update #13119

merged 3 commits into from
Nov 8, 2023

Conversation

rmitsch
Copy link
Contributor

@rmitsch rmitsch commented Nov 8, 2023

Description

LLM docs: OpenAI model update.

Types of change

Doc update.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added docs Documentation and website feat/llm Feature: LLMs (incl. spacy-llm) labels Nov 8, 2023
@rmitsch rmitsch self-assigned this Nov 8, 2023
@rmitsch rmitsch changed the base branch from master to docs/llm_main November 8, 2023 12:52
@rmitsch rmitsch mentioned this pull request Nov 8, 2023
Merged
3 tasks
@svlandeg
Copy link
Member

svlandeg commented Nov 8, 2023

Putting in draft so we don't merge before explosion/spacy-llm#356 is merged ;-)

@svlandeg svlandeg marked this pull request as draft November 8, 2023 14:57
svlandeg
svlandeg approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we link to https://platform.openai.com/docs/models/gpt-4-and-gpt-4-turbo and https://platform.openai.com/docs/models/gpt-3-5 respectively? I think that makes it easier for users to look up what we mean. Otherwise good to go!

@svlandeg svlandeg marked this pull request as ready for review November 8, 2023 16:41
@rmitsch
Copy link
Contributor Author

rmitsch commented Nov 8, 2023

Shall we link to https://platform.openai.com/docs/models/gpt-4-and-gpt-4-turbo and https://platform.openai.com/docs/models/gpt-3-5 respectively? I think that makes it easier for users to look up what we mean. Otherwise good to go!

Done in f996484.

@svlandeg svlandeg merged commit b2e831d into explosion:docs/llm_main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

@shadeMe shadeMe shadeMe approved these changes

Assignees

@rmitsch rmitsch

Labels
docs Documentation and website feat/llm Feature: LLMs (incl. spacy-llm)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmitsch @svlandeg @shadeMe