Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model name check for REST models #356

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Nov 8, 2023

Description

  • Remove model name check for REST models
  • Add new OpenAI registry functions for GPT-3.5 and GPT-4 without restrictions for model names.

Closes #351. Note that new, Literal-less registry functions for other REST models still have to be added.

Corresponding documentation PR

explosion/spaCy#13119

Types of change

Enhancement.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes
    • all external tests (i. e. pytest ran with --external)
    • all tests requiring a GPU (i. e. pytest ran with --gpu)
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added enhancement Improvement of existing feature feat/model Feature: models labels Nov 8, 2023
@rmitsch rmitsch self-assigned this Nov 8, 2023
@svlandeg svlandeg added Test external Run external tests and removed Test external Run external tests labels Nov 8, 2023
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for the quick turnover!

I cancelled the external tests because 1) OpenAI API is down and 2) the tests don't actually cover the new model names, right? I guess that would be overkill, to test every combination.

Nevertheless, I'd like us to hold off a bit on merging. If OpenAI's API comes back online, I'd like to just do a quick test locally.

@rmitsch
Copy link
Collaborator Author

rmitsch commented Nov 8, 2023

I cancelled the external tests because 1) OpenAI API is down and 2) the tests don't actually cover the new model names, right? I guess that would be overkill, to test every combination.

Yes, that applies to some older models as well. We are at a point where we don't test every model. We should discuss whether that's still something we want to do. If so, we should implement the smallest possible smoke test and parallelize them as much as possible.
I tested the new models locally and they work.

…l names. Remove model checks for REST models.
@rmitsch rmitsch changed the title Update OpenAI models Update OpenAI models & remove model name check for REST models Nov 8, 2023
@rmitsch rmitsch changed the title Update OpenAI models & remove model name check for REST models Remove model name check for REST models Nov 8, 2023
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small suggestions.

spacy_llm/models/rest/openai/registry.py Outdated Show resolved Hide resolved
spacy_llm/models/rest/openai/registry.py Outdated Show resolved Hide resolved
spacy_llm/tests/test_combinations.py Outdated Show resolved Hide resolved
@svlandeg svlandeg merged commit a461d48 into main Nov 8, 2023
11 checks passed
@svlandeg svlandeg deleted the chore/openai-model-update branch November 8, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature feat/model Feature: models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for new openai models
2 participants