chore(Android): Migrate Hermes Instruments to Kotlin #48378
+41
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
…utorFactory so it markes the NonNull values it overrides correctly.
TheRogue76
commented
Dec 24, 2024
| @@ -34,6 +35,7 @@ public void setDebuggerName(String debuggerName) { | |||
| mDebuggerName = debuggerName; | |||
| } | |||
|
|
|||
| @NonNull | |||
There was a problem hiding this comment.
JavaScriptExecutorFactory explicitly marks these values as non nullable, so it is ok to mark them here as well.
TheRogue76
commented
Dec 24, 2024
Comment on lines
-13
to
+14
| String getInternalStorage(); | ||
| public fun getInternalStorage(): String | ||
|
|
||
| String getId(); | ||
| public fun getId(): String |
There was a problem hiding this comment.
I marked these as String and not String? since in Cxx the return type is std::string and not a pointer, but i do see some pointer shenanigans going on over there. Will leave it up to the person who reviews to give their thoughts as well. I can not find any use of this class anywhere, in Cxx or in the JVM land so i can't tell by usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Time to migrate some of Hermes's instruments. I see that HermesMemoryDumper(
react/hermes/instrumentation/HermesMemoryDumper.h) implements the interface on C++,but not sure if i need to update the
getIdcall to justid(same withgetInternalStorage) or if the interop between Kotlin and Java applies to these things as well. @cortinico Any thoughts on your side would be appreciated.HermesSamplingProfiler just became an object, since it was a singleton and a static anyway.
Here is what HermesMemoryDumper.h looks like:
Updated: I ended up making them match the function signature on Cxx, because even if it does have that implicit behavior, doesn't feel right to tap into it like this.
Changelog:
[INTERNAL] [FIXED] - Migrate HermesMemoryDumper and HermesSamplingProfiler to Kotlin
Test Plan:
/gradlew test: