-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Android): Migrate Hermes Instruments to Kotlin #48378
Closed
TheRogue76
wants to merge
3
commits into
facebook:main
from
TheRogue76:feature/migrate-instruments-to-kotlin
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 0 additions & 32 deletions
32
...eactAndroid/src/main/java/com/facebook/hermes/instrumentation/HermesSamplingProfiler.java
This file was deleted.
Oops, something went wrong.
32 changes: 32 additions & 0 deletions
32
.../ReactAndroid/src/main/java/com/facebook/hermes/instrumentation/HermesSamplingProfiler.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Copyright (c) Meta Platforms, Inc. and affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
package com.facebook.hermes.instrumentation | ||
|
||
import com.facebook.soloader.SoLoader | ||
|
||
/** Hermes sampling profiler static JSI API. */ | ||
public object HermesSamplingProfiler { | ||
init { | ||
SoLoader.loadLibrary("jsijniprofiler") | ||
} | ||
|
||
/** Start sample profiling. */ | ||
@JvmStatic | ||
public external fun enable() | ||
|
||
/** Stop sample profiling. */ | ||
@JvmStatic | ||
public external fun disable() | ||
|
||
/** | ||
* Dump sampled stack traces to file. | ||
* | ||
* @param filename the file to dump sampling trace to. | ||
*/ | ||
@JvmStatic | ||
public external fun dumpSampledTraceToFile(filename: String) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ | |
|
||
package com.facebook.hermes.reactexecutor; | ||
|
||
import androidx.annotation.NonNull; | ||
import com.facebook.hermes.instrumentation.HermesSamplingProfiler; | ||
import com.facebook.react.bridge.JavaScriptExecutor; | ||
import com.facebook.react.bridge.JavaScriptExecutorFactory; | ||
|
@@ -34,6 +35,7 @@ public void setDebuggerName(String debuggerName) { | |
mDebuggerName = debuggerName; | ||
} | ||
|
||
@NonNull | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
@Override | ||
public JavaScriptExecutor create() { | ||
return new HermesExecutor(mConfig, mEnableDebugger, mDebuggerName); | ||
|
@@ -45,11 +47,12 @@ public void startSamplingProfiler() { | |
} | ||
|
||
@Override | ||
public void stopSamplingProfiler(String filename) { | ||
public void stopSamplingProfiler(@NonNull String filename) { | ||
HermesSamplingProfiler.dumpSampledTraceToFile(filename); | ||
HermesSamplingProfiler.disable(); | ||
} | ||
|
||
@NonNull | ||
@Override | ||
public String toString() { | ||
return "JSIExecutor+HermesRuntime"; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked these as
String
and notString?
since in Cxx the return type isstd::string
and not a pointer, but i do see some pointer shenanigans going on over there. Will leave it up to the person who reviews to give their thoughts as well. I can not find any use of this class anywhere, in Cxx or in the JVM land so i can't tell by usage