This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Fix C++ code generation for typed eigen matrices. #1688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Eigen distinguishes between matrices of bools, naturals and doubles; when generating a C++ fragment to construct a BMG graph, we always generated a double matrix, but that's bad; it will not type check when compiled by the C++ compiler since the BMG methods for constructing constant matrices require an input of the appropriate type.
Reviewed By: gafter, AishwaryaSivaraman
Differential Revision: D39632858