Skip to content
This repository has been archived by the owner on Dec 18, 2023. It is now read-only.

Fix C++ code generation for typed eigen matrices. #1688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix C++ code generation for typed eigen matrices. #1688

wants to merge 1 commit into from

Commits on Sep 20, 2022

  1. Fix C++ code generation for typed eigen matrices. 

    Summary: Eigen distinguishes between matrices of bools, naturals and doubles; when generating a C++ fragment to construct a BMG graph, we always generated a double matrix, but that's bad; it will not type check when compiled by the C++ compiler since the BMG methods for constructing constant matrices require an input of the appropriate type.

Reviewed By: gafter, AishwaryaSivaraman

Differential Revision: D39632858

fbshipit-source-id: aef37f30537fc690ed7756822a373f7411559669
    @ericlippert @facebook-github-bot
    ericlippert authored and facebook-github-bot committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    55cf333 View commit details
    Browse the repository at this point in the history