-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset Processing - Add support for groups, articulated scenes, episodes. #1886
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems functional for now and an improvement over existing process, so approving.
However, I do wonder if we could make this more generic by using MetadataMediator to load the SceneDataset and then enumerate the contents instead of directly querying the configs. I know that scene_instance access would be troubling, but the resulting config values would be more accurate since there is an override and defaults hierarchy built in.
Interested to get @jturner65's opinion on this.
Great point @aclegg3 ! It is possible to arrange the script differently, but I'm concerned about complicating its usage. |
… Add articulated scene support.
6c37569
to
aeceb3d
Compare
Motivation and Context
Motivations:
Context:
unity_dataset_processing.py
script is used to convert/decimate Habitat datasets into a format usable by Unity.Unity
has a clone of thedata
folder. A relative path from the data folder resolves both in Habitat and Unity (or any other external engine, like Blender).This changeset entirely refactors the
Habitat -> Unity
dataset processing pipeline such as:metadata.json
file is produced, containinggroups
.hydra
config.How Has This Been Tested
Tested with existing episode sets and new articulated scenes.
Types of changes
Checklist