-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparing for eventual rebase #2039
Draft
zephirefaith
wants to merge
93
commits into
main
Choose a base branch
from
0mdc/phase3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,802
−449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f/hitl-llm-interfacing
…f/hitl-llm-interfacing
* Make client loading state available to applications. * Simplify code.
* Add viewports. * Add viewports to rearrange_v2. * Improve viewport rect description.
…1959) * Add object visiblity and viewport visbility layers. * Hide self in viewports. * Don't render viewports if networking is disabled.
* Add viewports. * Add viewports to rearrange_v2. * Add object visiblity and viewport visbility layers. * Hide self in viewports. * Don't render viewports if networking is disabled. * Turn rearrange_v2 into a state machine. Add lobby. * Disable rearrange_v2 test. * Config changes. * Change episode termination states. * Add comment to lobby start session delay.
* Add session management. * Formatting changes. * Add clarifications to episode resolution. * Document temporary hack to check for client-side loading status. * Review pass - variable renaming and camera matrix chaching.
* Add session management. * Formatting changes. * Add clarifications to episode resolution. * Document temporary hack to check for client-side loading status. * Add session recorder, ui events and data upload. * Change path handling in session upload code.
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested
Types of changes
Checklist