Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] - add humnaoid data to CI download to activate the test_humanoid.py pytest #2084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BE] - add humnaoid data to CI download to activate the test_humanoid.py pytest #2084

wants to merge 1 commit into from

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Sep 23, 2024

Motivation and Context

I realized that test_humanoids.py pytest was being skipped on CI because the humanoid data was missing from the download. Added this back and now expecting the tests to run.

How Has This Been Tested

Should run the tests on CI now.
TODO: I noticed this fails locally due to missing config fields. Fix incoming.

Types of changes

  • [Refactoring] Large changes to the code that improve its functionality or performance
  • [Bug Fix] (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@aclegg3 aclegg3 requested review from xavierpuigf and 0mdc September 23, 2024 21:43
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 23, 2024
0mdc
0mdc approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch!

@aclegg3 aclegg3 mentioned this pull request Sep 23, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@xavierpuigf xavierpuigf Awaiting requested review from xavierpuigf

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @0mdc @facebook-github-bot