Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Null check for _is_object_visible raycast. #2121

Merged
merged 1 commit into from
Dec 19, 2024
Merged

HITL - Null check for _is_object_visible raycast. #2121

merged 1 commit into from
Dec 19, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Dec 16, 2024

Motivation and Context

This changeset adds a nullcheck to rearrange_v2's UI in _is_object_visible(), which caused failures in some rare cases.

How Has This Been Tested

Stress tested on 100k episodes.

Types of changes

  • [Bug Fix]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested a review from aclegg3 December 16, 2024 23:46
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 16, 2024
@0mdc 0mdc merged commit a12b42a into main Dec 19, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/hitl_is_object_visible_bugfix branch December 19, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot