Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mkretz/several fixes #128

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Mkretz/several fixes #128

wants to merge 4 commits into from

Conversation

mattkretz
Copy link
Collaborator

Each commit stands on its own. But I don't think it's helpful to make each one a PR.

@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 07:33 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 07:33 — with GitHub Actions Inactive
@mattkretz
CMake: Improve build type defaults
9cc68dc 
* Since we have -Og, -O0 (the default) is never a good idea.
* Building the project without a build type (the cmake default) is
  "usually not desirable" (cmake docs), therefore default to Release
  with assertions enabled.
* Document build types.
* Warn if the user somehow managed to build without optimization.
@mattkretz
Ensure that the node implementation matches expectations
e112b24 
... by testing for HasRequiredProcessFunction. If
HasRequiredProcessFunction fails, be helpful about the cause of the
problem via static_assert messages.

math_bulk_op in bm_case1 implemented both process_one and process_bulk.
Remove process_bulk to make it compile. This necessitates a move of the
process_bulk_requires_ith_output_as_span test to a different node type.

expect_sink in qa_scheduler implemented both process_one and
process_bulk. Remove process_one.
@mattkretz
Diagnose incorrect available_samples function signatures
a5f424a 
Declare available_samples as const in all node implementations.
@mattkretz
[WIP] Decimator test
9ecd828
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
@mattkretz mattkretz temporarily deployed to configure coverage July 21, 2023 10:46 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen Awaiting requested review from RalphSteinhagen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattkretz