Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mkretz/several fixes #128

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Mkretz/several fixes #128

wants to merge 4 commits into from

Commits on Jul 21, 2023

  1. CMake: Improve build type defaults 

    * Since we have -Og, -O0 (the default) is never a good idea.
* Building the project without a build type (the cmake default) is
  "usually not desirable" (cmake docs), therefore default to Release
  with assertions enabled.
* Document build types.
* Warn if the user somehow managed to build without optimization.
    @mattkretz
    mattkretz committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    9cc68dc View commit details
    Browse the repository at this point in the history

  2. Ensure that the node implementation matches expectations 

    ... by testing for HasRequiredProcessFunction. If
HasRequiredProcessFunction fails, be helpful about the cause of the
problem via static_assert messages.

math_bulk_op in bm_case1 implemented both process_one and process_bulk.
Remove process_bulk to make it compile. This necessitates a move of the
process_bulk_requires_ith_output_as_span test to a different node type.

expect_sink in qa_scheduler implemented both process_one and
process_bulk. Remove process_one.
    @mattkretz
    mattkretz committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    e112b24 View commit details
    Browse the repository at this point in the history

  3. Diagnose incorrect available_samples function signatures 

    Declare available_samples as const in all node implementations.
    @mattkretz
    mattkretz committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    a5f424a View commit details
    Browse the repository at this point in the history

  4. [WIP] Decimator test

    @mattkretz
    mattkretz committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    9ecd828 View commit details
    Browse the repository at this point in the history