Draft: Fix trigger threshold calculation for all scopes #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old calculation assumed that +5V always matches PSXXXX_MAX_VALUE,
however that is only the case for the ps3000 digital inputs.
On all analog inputs, the values which matches PSXXXX_MAX_VALUE depends on
the according range of the channel (ADC count)
(On AUX, the range is fixed to +/- 1V)
(This already was fixed for ps6000 in #86)
"Draft", because the changes build fine, but first need to be tested on all scope-types (check required voltage to actually trigger)
References (Check for method psXXXXSetSimpleTrigger ):
https://www.picotech.com/download/manuals/picoscope-4000-series-a-api-programmers-guide.pdf
https://www.picotech.com/download/manuals/PicoScope3000SeriesAApiProgrammersGuide.pdf
https://www.picotech.com/download/manuals/picoscope-6000-series-programmers-guide.pdf