Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Fix trigger threshold calculation for all scopes #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Draft: Fix trigger threshold calculation for all scopes #88

wants to merge 2 commits into from

Commits on Dec 14, 2021

  1. Fix trigger threshold calculation for all scopes 

    The old calculation assumed that +5V always matches PSXXXX_MAX_VALUE,
however that is only the case for the ps3000 digital inputs

On any other input, the values which matches PSXXXX_MAX_VALUE depends on
the according range of the channel (ADC count)
    @alexxcons
    alexxcons committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    7066fe6 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. Use existing cached d_max_value instead of re-calling 

    psXXXXaMaximumValue again
    @alexxcons
    alexxcons committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    9074ad2 View commit details
    Browse the repository at this point in the history