-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(falco): chart for falco 0.37.0 #601
Conversation
9960f35
to
b03be0f
Compare
b03be0f
to
014b02e
Compare
4feb8c3
to
bed2777
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review. This is awesome 🤩
I've just found some very minor issues (see comment below) and left some notes.
Also, please double check falco.yaml
near to the release since some minor changes have been already introduced.
bed2777
to
5297bdf
Compare
5297bdf
to
6a9cb24
Compare
b50f92c
to
26e2c87
Compare
9f0748d
to
e67d95a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific job 👏
I just left some comments and reminders (in particular, we are going to release falco-rules 3.0, then we will need to update the version here).
Signed-off-by: Aldo Lacuku <[email protected]>
The defualt mode to get kubernetes metadata is using the k8s-metacollector and the k8smeta plugin. This commit adds the required helpers and variables to enable the k8s-metacollector by default. Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
9fe5b1a
to
bf3c70b
Compare
Signed-off-by: Aldo Lacuku <[email protected]>
bf3c70b
to
ee0ef99
Compare
Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
Signed-off-by: Aldo Lacuku <[email protected]>
ee0ef99
to
ec98464
Compare
/hold until falco 0.37.0 is out. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 9d9abe1944ed09f4c5954dfef16b60834820c477
|
/hold cancel |
🥳 |
What type of PR is this?
/kind cleanup
/kind documentation
/kind feature
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
New chart for Falco
037.0
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist