new(pkg/driver): fixed some kernel version related issues. #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
commented
Dec 4, 2023
| @@ -125,7 +126,7 @@ func getOSReleaseDistro(kr *kernelrelease.KernelRelease) (Distro, error) { | |||
| } | |||
|
|
|||
| func toURL(repo, driverVer, fileName, arch string) string { | |||
| return fmt.Sprintf("%s/%s/%s/%s", repo, driverVer, arch, fileName) | |||
| return fmt.Sprintf("%s/%s/%s/%s", repo, url.QueryEscape(driverVer), arch, fileName) | |||
There was a problem hiding this comment.
Also, properly escape the driverVersion that contains a +driver.
Signed-off-by: Federico Di Pierro <[email protected]> Co-authored-by: Aldo Lacuku <[email protected]>
alacuku
approved these changes
Dec 4, 2023
leogr
approved these changes
Dec 4, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone v0.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area library
/area tests
What this PR does / why we need it:
Store full kernelversion in
driverkernel.FetchInfo(), instead of already modifying it.This way, all of the distro-specific logic can assume it receives the full
uname -voutput.This fixes a bug with debian distro.
Also, properly
QueryEscapedriver version while building up the download url, because it contains a+driver.This fixes drivers download.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: