-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kernel_crawler): support debian rpi. #192
Conversation
/hold |
We are finding no headers for |
Signed-off-by: Federico Di Pierro <[email protected]>
f88b68c
to
d337b01
Compare
print(line) | ||
raise | ||
# Just skip the line if it is malformed | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Malformed lines can happen; in my tests, a line Description:
was breaking this. Just skip it.
@@ -31,6 +31,7 @@ def __init__(self, arch): | |||
mirrors = [ | |||
deb.DebMirror('http://mirrors.edge.kernel.org/debian/', arch, repo_filter), | |||
deb.DebMirror('http://security.debian.org/', arch, repo_filter), | |||
deb.DebMirror('http://archive.raspberrypi.com/debian/', arch, repo_filter), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debian mirror for raspberrypi.
@@ -58,7 +59,8 @@ def to_driverkit_config(self, release, deps): | |||
headers = [] | |||
headers_rt = [] | |||
headers_cloud = [] | |||
# Magic to obtain `rt`, `cloud` and normal headers: | |||
headers_rpi = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic to handle headers for rpi.
return [repo.DriverKitConfig(release + "-" + self.arch, "debian", headers), | ||
repo.DriverKitConfig(release + "-rt-" + self.arch, "debian", headers_rt), | ||
repo.DriverKitConfig(release + "-cloud-" + self.arch, "debian", headers_cloud)] | ||
final = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only add headers for which we found at least 3 packages.
content = get_url(url) | ||
# If content is None and we got elements after this one, | ||
# try the next ones. | ||
if content is not None or idx == len(urls) - 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If get_url
returns None content, try the next one instead of returning None.
/cc @EXONER4TED |
/cc @leogr |
Crawled rpi kernels:
|
/unhold |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area crawler
What this PR does / why we need it:
Add support for debian rpi kernels.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: