Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(config): (re)move zig #1637

Merged
merged 1 commit into from
Sep 25, 2024
Merged

update(config): (re)move zig #1637

merged 1 commit into from
Sep 25, 2024

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Sep 25, 2024

Due to a necessary patch release in libs we need to disable required checks for zig builds since that is not enabled on the release branch. Partially reverts #1635 (we know what we doing).

Signed-off-by: Luca Guerra <[email protected]>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Sep 25, 2024

LGTM label has been added.

Git tree hash: 9304708fe96c2eaebd499f048a11462fc713a40b

@FedeDP
Copy link
Contributor

FedeDP commented Sep 25, 2024

Thanks luca!

@poiana poiana merged commit 4130b9c into master Sep 25, 2024
5 checks passed
@poiana poiana deleted the LucaGuerra-patch-1 branch September 25, 2024 12:52
@poiana
Copy link
Contributor

poiana commented Sep 25, 2024

@LucaGuerra: Updated the config configmap in namespace default at cluster default using the following files:

  • key config.yaml using file config/config.yaml

In response to this:

Due to a necessary patch release in libs we need to disable required checks for zig builds since that is not enabled on the release branch. Partially reverts #1635 (we know what we doing).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants